Conversation
|
Hey. I think you forked from the wrong place. Check this: https://github.com/chilipeppr-grbl/widget-grbl-autolevel Looks like /raykholo is 11 months old while chilipeppr-grbl is 8 months old. Can you compare the 2 repos to see what changes may exist between them? |
|
that is odd.
I have just tried to fork the repo from chilipeppr-grbl again and it still references that it is forked from raykholo.
if you look at the readme for this widget (in your repo) the loadURL is still pulling from the original raykholo.
so overall this needs some work.
… On 22 Jun 2017, at 15:34, raykholo ***@***.***> wrote:
Hey. I think you forked from the wrong place. Check this: https://github.com/chilipeppr-grbl/widget-grbl-autolevel <https://github.com/chilipeppr-grbl/widget-grbl-autolevel>
Looks like /raykholo is 11 months old while chilipeppr-grbl is 8 months old. Can you compare the 2 repos to see what changes may exist between them?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX4Egah80OIlncFqnuAr7UWsyDUYVdLqks5sGntsgaJpZM4OB546>.
|
|
To be clear, the grbl workspace: https://github.com/chilipeppr-grbl/workspace-grbl The reason for this is that Cloud9 will not let a github organization have an account (last I checked) so I have to do the editing in C9 raykholo, we test via chilipeppr /grblStaging which points to raykholo and then /grblRelease which is identical to /grbl but we can force refresh the /grblRelease first to check nothing breaks, fix or roll back if there's a problem Anyways, since I can't have a chilipeppr-grbl C9, the runme never runs when it's in that repo, and hence all the readme's point to raykholo github. YEPP, it's a mouthful. Look here: https://github.com/chilipeppr-grbl/workspace-grbl/blob/master/workspace.js#L275 The workspace does indeed point to the chilipeppr-grbl autolevel widget. Any thoughts? |
|
if your staging repo points to raykholo then that seems fine. do the pull from raykholo and work up from there?
in any event, the result of this multi-stage strategy is that people wanting to fork, click the down arrow in the widget menu and end up in the wrong place (as I did)! That really is something that should be avoided, don’t you agree?
there are only four sets of changes that i have pushed for this widget. If you want to update the grbl workspace then perhaps a manual change is the best approach. You can see the changes in the pull request. Certainly doing that will take a lot less time than manually comparing the repos ….
i was going to prepare the whole grbl workspace and the grbl widget for pull requests but given your comments that sounds too much like a headache. When I’m ready for a proper release I’ll ask john to link to /jpadie as a grbl 1.1+ workspace. that has a much simpler hierarchical organisation and can more easily take forks and pulls. Not great branding but that’s life.
… On 22 Jun 2017, at 21:16, raykholo ***@***.***> wrote:
To be clear, the grbl workspace: https://github.com/chilipeppr-grbl/workspace-grbl <https://github.com/chilipeppr-grbl/workspace-grbl>
also thinks (in the readme) that it's from raykholo, but it is in fact chilipeppr-grbl.
The reason for this is that Cloud9 will not let a github organization have an account (last I checked) so I have to do the editing in C9 raykholo, we test via chilipeppr /grblStaging which points to raykholo and then /grblRelease which is identical to /grbl but we can force refresh the /grblRelease first to check nothing breaks, fix or roll back if there's a problem
Anyways, since I can't have a chilipeppr-grbl C9, the runme never runs when it's in that repo, and hence all the readme's point to raykholo github. YEPP, it's a mouthful.
Look here: https://github.com/chilipeppr-grbl/workspace-grbl/blob/master/workspace.js#L275 <https://github.com/chilipeppr-grbl/workspace-grbl/blob/master/workspace.js#L275>
The workspace does indeed point to the chilipeppr-grbl autolevel widget.
Any thoughts?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX4EgW2yP6hpyGUFQXb7u2QAW0s2oNUNks5sGsuhgaJpZM4OB546>.
|
2 participants
three core fixes:
for the autofill coordinates, we need to take account of the use case where the origin is not on a vertex. so add back the b.box.min.x/y
the code fails catastrophically when the lyr object has a property of material that doesn't have a subproperty of opacity. capture the use case and handle gracefully.
need to publish to probing pub sub when the auto-levelling is stopped/started.
ignore the changes to readme and autogenerated*. these should be regenerated by the runme.js applet.